Skip to content

perf: avoid AST traversal to fill the IdToEObjectMap in the rootNode #2284

perf: avoid AST traversal to fill the IdToEObjectMap in the rootNode

perf: avoid AST traversal to fill the IdToEObjectMap in the rootNode #2284

Triggered via pull request February 24, 2025 14:56
Status Failure
Total duration 2m 22s
Artifacts 1

verify.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 2 warnings
Usage of System.out/err: com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/ProxyCompositeNode.java#L88
References to System.(out|err).print are usually intended for debugging purposes and can remain in the codebase even in production code. By using a logger one can enable/disable this behaviour at will (and by priority) and avoid clogging the Standard out log. SystemPrintln (Priority: 2, Ruleset: Best Practices) https://docs.pmd-code.org/pmd-doc-7.7.0/pmd_rules_java_bestpractices.html#systemprintln
Usage of System.out/err: com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/ProxyCompositeNode.java#L92
References to System.(out|err).print are usually intended for debugging purposes and can remain in the codebase even in production code. By using a logger one can enable/disable this behaviour at will (and by priority) and avoid clogging the Standard out log. SystemPrintln (Priority: 2, Ruleset: Best Practices) https://docs.pmd-code.org/pmd-doc-7.7.0/pmd_rules_java_bestpractices.html#systemprintln
Usage of System.out/err: com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/ProxyCompositeNode.java#L97
References to System.(out|err).print are usually intended for debugging purposes and can remain in the codebase even in production code. By using a logger one can enable/disable this behaviour at will (and by priority) and avoid clogging the Standard out log. SystemPrintln (Priority: 2, Ruleset: Best Practices) https://docs.pmd-code.org/pmd-doc-7.7.0/pmd_rules_java_bestpractices.html#systemprintln
pmd
Process completed with exit code 1.
maven-verify
Process completed with exit code 1.
Avoid using implementation types like 'ArrayList'; use the interface instead: com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingResourceStorageLoadable.java#L180
Excessive coupling to implementation types (e.g., `HashSet`) limits your ability to use alternate implementations in the future as requirements change. Whenever available, declare variables and parameters using a more general type (e.g, `Set`). This rule reports uses of concrete collection types. User-defined types that should be treated the same as interfaces can be configured with the property `allowedTypes`. LooseCoupling (Priority: 3, Ruleset: Best Practices) https://docs.pmd-code.org/pmd-doc-7.7.0/pmd_rules_java_bestpractices.html#loosecoupling
maven-verify
No files were found with the provided path: /com.avaloq.tools.ddk.xtext.test/target/work/data/.metadata/.log. No artifacts will be uploaded.

Artifacts

Produced during runtime
Name Size
PMD Report
1.17 KB