Support for Unicode pathnames and user-mount convenience #154
Conversation
… option into fstab, so anyone can mount the filesystem, if they have access to the creds file...
|
For the newest release 0.14.8 your commit for ut8 requires changes. The new patch just keeps the normal_entry.py modifications, given the opened_file.py ones are no longer required, neither match the current code: https://github.com/dsoprea/GDriveFS/files/367583/pull_154_utf8.txt |
| @@ -852,6 +852,10 @@ def mount(auth_storage_filepath, mountpoint, debug=None, nothreads=None, | |||
| else: | |||
| v = True | |||
|
|
|||
| # ignore the "user" option so we can put in fstab easily | |||
| if k == "user": | |||
There was a problem hiding this comment.
I'm not clear on why we need this. If we receive an unsupported option, it's just forwarded to FUSE. In this case, there is no such "user" option. So, it should work fine without this change.
There was a problem hiding this comment.
In a previous version I received an error when I put 'user' in the options in fstab, when I wanted to make mounting the GDriveFS user-mountable. I haven't used GDriveFS in a while, so I have no problem if you simply reject it. Sorry for causing a stir.
Hi,
I'd like to suggest these 2 commits, to support unicode pathnames, and to help with fstab installs, by letting a non-root user mount an fstab-configured Google Drive filesystem.
Hope you'll consider these.
Thanks,