Add support for reading and writing encrypted archives with test suites #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 50
💛 - Coveralls |
|
I found the issue with Python 2.7, it's related to a call to bytes which works perfectly with Python3 but not Python2. Do I need to add version check to call the right function depending on Py2 or Py3? Do you still want to support Python2.7? Based on your feedback, I'll commit the patch. |
Calls bytes with Python3 and unicode with Python2
|
Sorry for the previous commit which only fixed python2 and not python3. Now all tests are green! |
|
Did you have time to check this PR? |
|
Hello, Any news to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.