-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EKS as separate description #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vradicevicds
changed the title
Implement EKS as seperate description
Implement EKS as separate description
Nov 27, 2024
vradicevicds
force-pushed
the
eks/cluster
branch
from
December 3, 2024 09:14
ded4244
to
37294b2
Compare
sgrdn
reviewed
Dec 9, 2024
sgrdn
reviewed
Dec 9, 2024
sgrdn
reviewed
Dec 9, 2024
sgrdn
reviewed
Dec 9, 2024
sgrdn
reviewed
Dec 9, 2024
sgrdn
reviewed
Dec 9, 2024
sgrdn
reviewed
Dec 9, 2024
sgrdn
reviewed
Dec 9, 2024
vradicevicds
commented
Dec 9, 2024
sgrdn
reviewed
Dec 9, 2024
modules/eks/oidc.tf
Outdated
@@ -0,0 +1,12 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove empty lines from start of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Missing descriptions added for the output variables.
mariogluhakovic
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces eks module,
modules/eks
. By using this branch, user is able to deploy "nodeless" EKS.Simphera instance, node groups, logging, patch manager, eks addons and efs storage class are disabled to simplify implementation of this feature.
Terraform v1.9.4
on windows_amd64