Updates for DSS C-API 0.12.x #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there is an actual error on macOS related to meters (probably uninitialized memory), but the rest is a bunch of timeouts, e.g. I'll try to fix the meter issue and rerun the tests later. |
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 71.18% 71.23% +0.04%
==========================================
Files 44 44
Lines 5810 5813 +3
==========================================
+ Hits 4136 4141 +5
+ Misses 1674 1672 -2
Continue to review full report at Codecov.
|
|
Some old functions were still not exposed, this could be a good time to do it. |
This was referenced Apr 13, 2022
PMeira
force-pushed
the
dss_capi-0.12.x
branch
2 times, most recently
from
b3c08ba to
e35e49c
Compare
- Update version, use DSS_CAPI_TAG = "0.12.0" - Updated lib names - LoadShapes: migrate the spelling of SInterval C functions - Transformers: Xhl/Xht/Xlt and R are (correctly) percent values now. - In properties in general, DSS Objects are always lowercase now, since we don't keep copies of the original strings anymore in DSS C-API. - Monitors: Bytestream no longer contains header. - Some setters now throw instead of silently accepting invalid values. - LineCodes: C1, C0 in nF. - Loads: ZipV is always 7 elements. - tests/Executive: update number of commands - COMHelp was added in 0.12.0b4 - lib: Remove the old function aliases for LoadShapes - YMatrix: update API (to simple pointer); add `SolveSystem()` without params - tests/CktElement.AllVariableValues: make it a little lax (win32 failed) - tests/meters: Run "AllocateLoads" to populate CalcCurrent and AllocFactors - SwtControls: enable Idx getter and related tests - Add support for ARM64/M1 on macOS. Tested with Julia 1.8rc, tests pass. Linux added too, but untested currently. - deps: download help; use it (DSS_SetPropertiesMO)
|
I think we're safe to merge and release soon. I'll push another commit to set the version to 0.8.0 |
kdheepak
approved these changes
Jul 13, 2022
|
Thanks for making these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
The unit changes were fixes ported from the main OpenDSS, as well as the Bytestream change.
Main DSS C-API PR was at dss-extensions/dss_capi#109, and the announcement at https://github.com/dss-extensions/dss_capi/releases/tag/0.12.0
On the Julia side, this is a conservative update. I opened #81, #82 and #83 regarding new features.