Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download dstack-runner to well-known location #2179

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Download dstack-runner to well-known location #2179

merged 1 commit into from
Jan 10, 2025

Conversation

un-def
Copy link
Collaborator

@un-def un-def commented Jan 9, 2025

  • The default location of runner is /usr/local/bin/dstack-runner now, not a temp directory
  • It's possible to override the location with --runner-binary-path
  • If the runner already exists, shim does not download it again
  • When provisioning an instance, server removes runner to ensure we have matching runner version

Fixes: #2051

@un-def
Download dstack-runner to well-known location
fa3b934 
* The default location of runner is /usr/local/bin/dstack-runner now,
  not a temp directory
* It's possible to override the location with `--runner-binary-path`
* If the runner already exists, shim does not download it again
* When provisioning an instance, server removes runner to ensure
  we have matching runner version

Fixes: #2051
@un-def un-def requested a review from r4victor January 9, 2025 13:04
@un-def un-def merged commit d8899ae into master Jan 10, 2025
24 checks passed
@un-def un-def deleted the issue_2051_download_runner_to_well_known_location branch January 10, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4victor r4victor r4victor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: The missing runner binary leads to CREATING_CONTAINER_ERROR after clearing /tmp
2 participants
@un-def @r4victor