Skip to content

Commit

Permalink
Failed test_non_zero_cost shows filename
Browse files Browse the repository at this point in the history
  • Loading branch information
Sergey Mezentsev authored and TheBits committed Mar 1, 2024
1 parent 7ec2056 commit f87d6c6
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 10 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/catalogs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ on:
schedule:
- cron: '0 1 * * *' # 01:00 UTC every day

env:
PIP_DISABLE_PIP_VERSION_CHECK: on
PIP_DEFAULT_TIMEOUT: 10
PIP_PROGRESS_BAR: off

jobs:
catalog-aws:
name: Collect AWS catalog
Expand Down
23 changes: 13 additions & 10 deletions src/integrity_tests/test_all.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
import csv
import os
from pathlib import Path
from typing import List

import pytest

files = sorted(Path(os.environ["CATALOG_DIR"]).glob("*.csv"))

@pytest.fixture
def catalog_files(catalog_dir: Path) -> List[Path]:
return list(catalog_dir.glob("*.csv"))

def catalog_name(catalog) -> str:
return catalog.name


class TestAllCatalogs:
def test_non_zero_cost(self, catalog_files: List[Path]):
for file in catalog_files:
with open(file, "r") as f:
reader = csv.DictReader(f)
prices = [float(row["price"]) for row in reader]
assert 0 not in prices
@pytest.fixture(params=files, ids=catalog_name)
def catalog(self, request):
yield request.param

def test_non_zero_cost(self, catalog):
reader = csv.DictReader(catalog.open())
for row in reader:
assert float(row["price"]) != pytest.approx(0), str(row)

0 comments on commit f87d6c6

Please sign in to comment.