-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Commit: Add vultr support #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bihan, thanks for the PR. I looked through it briefly and left some comments, please feel free to respond to them if you have the time. I may add a few more comments later though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bihan, thanks for the update. I looked through the changes and the resulting catalog (python -m gpuhunt vultr --output vultr.csv
) and found a few more edge cases that seem to yield incorrect results. Hope you can address these too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bihan, thanks for the update, there are just a few comments left before this PR is good to merge.
@jvstme I have modified
I think this solves the above issues. Regarding L40s, it is still not available to verify it experimentally. Currently I have considered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bihan, thanks, I added a couple more suggestions - please see if you agree with them and we can merge the PR then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
No description provided.