Issue 45 failed srcintegrity teststest allpytestallcatalogstest non zero cost

.github/workflows/catalogs.yml

@@ -9,6 +9,11 @@ on:
   schedule:
     - cron: '0 1 * * *'  # 01:00 UTC every day
 
+env:
+  PIP_DISABLE_PIP_VERSION_CHECK: on
+  PIP_DEFAULT_TIMEOUT: 10
+  PIP_PROGRESS_BAR: off
+
 jobs:
   catalog-aws:
     name: Collect AWS catalog

src/gpuhunt/providers/azure.py

@@ -1,5 +1,6 @@
 import json
 import logging
+import math
 import os
 import re
 import time
@@ -146,10 +147,13 @@ def get(
                     continue
                 if not item["armSkuName"]:
                     continue
+                price = float(item["retailPrice"])
+                if math.isclose(price, 0):
+                    continue
                 offer = RawCatalogItem(
                     instance_name=item["armSkuName"],
                     location=item["armRegionName"],
-                    price=item["retailPrice"],
+                    price=price,
                     spot="Spot" in item["meterName"],
                     cpu=None,
                     memory=None,

src/integrity_tests/test_all.py

@@ -1,19 +1,22 @@
 import csv
+import os
 from pathlib import Path
-from typing import List
 
 import pytest
 
+files = sorted(Path(os.environ["CATALOG_DIR"]).glob("*.csv"))
 
-@pytest.fixture
-def catalog_files(catalog_dir: Path) -> List[Path]:
-    return list(catalog_dir.glob("*.csv"))
+
+def catalog_name(catalog) -> str:
+    return catalog.name
 
 
 class TestAllCatalogs:
-    def test_non_zero_cost(self, catalog_files: List[Path]):
-        for file in catalog_files:
-            with open(file, "r") as f:
-                reader = csv.DictReader(f)
-                prices = [float(row["price"]) for row in reader]
-            assert 0 not in prices
+    @pytest.fixture(params=files, ids=catalog_name)
+    def catalog(self, request):
+        yield request.param
+
+    def test_non_zero_cost(self, catalog):
+        reader = csv.DictReader(catalog.open())
+        for row in reader:
+            assert float(row["price"]) != pytest.approx(0), str(row)