Allow regular expression URI matching from a JSON recording #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great feature! Couple comments inline. |
| }]; | ||
| } | ||
|
|
||
| return recording; |
There was a problem hiding this comment.
Should we use a field other than 'uri' for regex matchers? If we can do that, then we keep the regexes out of the responseDictionary (good since they'll never be a valid key) and we only enumerate the regexes.
|
@epologee definitely interested in merging this, wdyt of differentiating between url and regex matchers (inline comment above)? |
|
Cool! Your comments are valid. Just haven't gotten around to it. Will try |
|
Awesome - maybe uri-regex for that parameter? No strong opinions though. |
|
closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in /issues/23, my server's API uses time-based hashes in the URI, which breaks the recoring-lookup by VCR.
Because the URI structure is always the same, with merely the hash changing, I wanted to propose allowing regular expression matches in the recorded JSON files to get VCR to work with expected changes in the URI.
I've added three test methods to cover the added behavior, without breaking the existing one.
Is this something you'd consider merging, @dstnbrkr?