Create an interface for the executors that can log errors, so that we can call it from the exporters #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able to call this anywhere without knowing if retrying is enabled
skvinay-git
reviewed
Dec 7, 2023
| */ | ||
| abstract class InMemoryExceptionLogger { | ||
| private Map<String, ErrorDetail> errors; | ||
| private Map<String, ErrorDetail> recentErrors; |
There was a problem hiding this comment.
both seem to be the same. Unclear why we have 2 fields?
skvinay-git
suggested changes
Dec 7, 2023
| private Map<String, ErrorDetail> recentErrors; | ||
|
|
||
| private void logError(String idempotentId, ErrorDetail errorDetail) { | ||
| this.errors.put(idempotentId, errorDetail); |
| @@ -34,7 +34,7 @@ | |||
| import java.util.concurrent.Callable; | |||
|
|
|||
| /** A {@link IdempotentImportExecutor} that stores known values in memory. */ | |||
| public class InMemoryIdempotentImportExecutor implements IdempotentImportExecutor { | |||
| public class InMemoryIdempotentImportExecutor extends InMemoryExceptionLogger implements IdempotentImportExecutor { | |||
| private final Map<String, Serializable> knownValues = new HashMap<>(); | |||
| private final Map<String, ErrorDetail> errors = new HashMap<>(); | |||
| private final Map<String, ErrorDetail> recentErrors = new HashMap<>(); | |||
There was a problem hiding this comment.
I am not sure this is right. It looks like the executor has 2 sets or errors and adds / removes from them. In your new class, you have your own set. And always add to both. I feel it is a bug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.