Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments: update MsgTestController with dtm server compatibility note #83

Merged

Conversation

wooln
Copy link
Contributor

@wooln wooln commented Dec 6, 2024

在Sample示例的[HttpGet("msg-mssqlqueryprepared")]方法上增加注释,解释从dtm server v1.10开始对回调QueryPrepared返回状态的处理修改,以及提醒异常body内容但状态码是200时会被当成正常从而造成bug.

场景,MSG模式
前提: 读写屏障表的链接信息配置不正确
步骤:

  1. 向dtm注册全局事务-prepared
  2. 插入屏障表失败
  3. 回调应用的http的QueryPrepared, 得到http200 body是"Object reference not set to an instance of an object.",通过HTTPResp2DtmError方法判定为无异常的正常,MSG事务被错误的commited了。

- Add comment explaining compatibility changes in dtm server v1.10
- Highlight changes in HTTP status code handling- Reference specific code in dtm/client/dtmcli/utils.go for implementation details
@catcherwong catcherwong merged commit 9f90cc1 into dtm-labs:main Dec 7, 2024
0 of 3 checks passed
@wooln wooln deleted the comments-QueryPrepared-http-status-code branch December 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants