chore: clippy let-underscore-untyped #1218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy keeps complaining about https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped Seems like a noop, esp considering that @dtolnay has filed a bug in rust-lang/rust-clippy#10411 One issue though is that MSRV in .clippy.toml is not matching the one in Cargo.toml: * .clippy.toml: msrv = "1.48.0" * Cargo.toml: rust-version = "1.60" Which one is the accurate one? I would assume its the Cargo.toml, in which case it might be better to apply this change?
dtolnay
reviewed
May 27, 2023
|
@dtolnay thx, i wasn't sure if its applicable or not. What about the difference in MSRV? |
|
I think it's fine. Some of the crates in the workspace have a different supported rust-version from one another. |
But if they are different, shouldn't clippy rules be relevant to each specific crate? I honestly don't understand the need for a global clippy-only MSRV -- maybe there is some other reason I'm missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy keeps complaining about
https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_untyped
Seems like a noop, esp considering that @dtolnay has filed a bug in
rust-lang/rust-clippy#10411
One issue though is that MSRV in .clippy.toml is not matching the one in Cargo.toml:
Which one is the accurate one? I would assume its the Cargo.toml, in which case it might be better to apply this change?