Skip to content

Delete #[automatically_derived] on impl blocks that are not trait impls #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Jul 19, 2025

Rustc nightly-2025-07-19 has begun warning about this. rust-lang/rust#143845

warning: `#[automatically_derived]` only has an effect on trait implementation blocks
  --> demo/src/main.rs:23:12
   |
23 |         fn put(&self, parts: &mut MultiBuf) -> u64;
   |            ^^^
   |
   = note: `#[warn(unused_attributes)]` on by default

warning: `#[automatically_derived]` only has an effect on trait implementation blocks
  --> demo/src/main.rs:24:12
   |
24 |         fn tag(&self, blobid: u64, tag: &str);
   |            ^^^

warning: `#[automatically_derived]` only has an effect on trait implementation blocks
  --> demo/src/main.rs:25:12
   |
25 |         fn metadata(&self, blobid: u64) -> BlobMetadata;
   |            ^^^^^^^^

Rustc nightly-2025-07-19 has begun warning about this.

    warning: `#[automatically_derived]` only has an effect on trait implementation blocks
      --> demo/src/main.rs:23:12
       |
    23 |         fn put(&self, parts: &mut MultiBuf) -> u64;
       |            ^^^
       |
       = note: `#[warn(unused_attributes)]` on by default

    warning: `#[automatically_derived]` only has an effect on trait implementation blocks
      --> demo/src/main.rs:24:12
       |
    24 |         fn tag(&self, blobid: u64, tag: &str);
       |            ^^^

    warning: `#[automatically_derived]` only has an effect on trait implementation blocks
      --> demo/src/main.rs:25:12
       |
    25 |         fn metadata(&self, blobid: u64) -> BlobMetadata;
       |            ^^^^^^^^
@dtolnay dtolnay merged commit 8531c59 into master Jul 19, 2025
38 checks passed
@dtolnay dtolnay deleted the autderive branch July 19, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant