Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate expr scanner to table driven #1779

Merged
merged 5 commits into from
Nov 2, 2024
Merged

Translate expr scanner to table driven #1779

merged 5 commits into from
Nov 2, 2024

Commits on Nov 2, 2024

  1. Extract non-full expr scanner to module

    @dtolnay
    dtolnay committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7c102c3 View commit details
    Browse the repository at this point in the history

  2. Make scan_expr compilable from integration test

    @dtolnay
    dtolnay committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    0132c44 View commit details
    Browse the repository at this point in the history

  3. Test that every expr can be scanned

    @dtolnay
    dtolnay committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    8039cb3 View commit details
    Browse the repository at this point in the history

  4. Translate expr scanner to table driven

    @dtolnay
    dtolnay committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ca97c7d View commit details
    Browse the repository at this point in the history

  5. Ignore enum_glob_use pedantic clippy lint 

        warning: usage of wildcard import for enum variants
     --> src/scan_expr.rs:1:12
      |
    1 | use self::{Action::*, Input::*};
      |            ^^^^^^^^^ help: try: `Action::{DecDepth, Finish, IncDepth, SetState}`
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use
      = note: `-W clippy::enum-glob-use` implied by `-W clippy::pedantic`
      = help: to override `-W clippy::pedantic` add `#[allow(clippy::enum_glob_use)]`

    warning: usage of wildcard import for enum variants
     --> src/scan_expr.rs:1:23
      |
    1 | use self::{Action::*, Input::*};
      |                       ^^^^^^^^ help: try: `Input::{CanBeginExpr, ConsumeAny, ConsumeBinOp, ConsumeBrace, ConsumeDelimiter, ConsumeIdent, ConsumeLifetime, ConsumeLiteral, ConsumeNestedBrace, Empty, ExpectPath, ExpectTurbofish, ExpectType, Keyword, Otherwise, Punct}`
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use
    @dtolnay
    dtolnay committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    0986a66 View commit details
    Browse the repository at this point in the history