Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old checkpoints from finalization state #1083

Merged
merged 3 commits into from
May 9, 2019
Merged

Cleanup old checkpoints from finalization state #1083

merged 3 commits into from
May 9, 2019

Commits on May 9, 2019

  1. Clenup old checkpoints from finalization state 

    This fix significantly reduces individual finalization state size.

In a test, I run 1 proposer with 4 finalizers with configuration epoch_length=2.
After processing ~9k blocks and ~4.5k epochs, finalization state size was 767599.
After applying this PR, it has been reduced to 196002. More finalizers we have,
more memory we save, because checkpoints map holds votes from every finalizer.

Signed-off-by: Stanislav Frolov <[email protected]>
    @frolosofsky
    frolosofsky committed May 9, 2019
    Configuration menu
    Copy the full SHA
    df0dd7d View commit details
    Browse the repository at this point in the history

  2. Add test, update logs 

    Signed-off-by: Stanislav Frolov <[email protected]>
    @frolosofsky
    frolosofsky committed May 9, 2019
    Configuration menu
    Copy the full SHA
    d751b58 View commit details
    Browse the repository at this point in the history

  3. be polite man 

    Signed-off-by: Stanislav Frolov <[email protected]>
    @frolosofsky
    frolosofsky committed May 9, 2019
    Configuration menu
    Copy the full SHA
    70c6b4f View commit details
    Browse the repository at this point in the history