Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off Mergeable's reminders on stale issues and pull requests #455

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

cornelius
Copy link
Member

@cornelius cornelius commented Jan 18, 2019

This pull request is the suggestion to turn off the messages on stale issues and pull requests. These messages create some noise and usually don't seem to be too helpful.

Don't let Mergeable add comments on issues and pull requests anymore
which are opened for a longer time. These messages create some
noise and usually don't seem to be too helpful.

Signed-off-by: Cornelius Schumacher <[email protected]>
@cornelius cornelius added the repo Configuration of the repository itself label Jan 18, 2019
@@ -15,17 +15,11 @@ mergeable:
must_include:
regex: "^.{10,}"
message: 'The description must not be empty (at least 10 characters)!'
stale:
days: 10
message: 'There has not been any activity in the past 10 days. Is this still active?'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR says to turn off mergeable notifications for issues but it seems it also removes it for pull requests too, doesn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, technically pull requests are issues as well, but you are right. I'll clarify this in the summary.

@cornelius cornelius changed the title Switch off Mergeable's messages on stale issues Switch off Mergeable's messages on stale issues and pull requests Jan 18, 2019
Copy link
Member

@kostyantyn kostyantyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e1014bf

I don't see the benefit of this mergeable notification as it only creates the noise. What might be interesting is an alternative of Bitcoin bot that closes the issue/PR if it was untouched for a couple of months just to clean up the backlog.

Copy link
Member

@Gnappuraz Gnappuraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e1014bf

@scravy
Copy link
Member

scravy commented Jan 18, 2019

I for one do find them helpful. I‘d maybe just increase the threshold.

Copy link
Member

@thothd thothd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also rather have it off, since notifications became quite noisy and I can imagine that with 2-3x the volume of issues it won't be manageable
utACK e1014bf

Copy link

@castarco castarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK I also find that these notifications were too noisy, and the problem can only be worse as more people join the project and its activity increase.

@scravy
Copy link
Member

scravy commented Jan 18, 2019

I'm not opposed to it, and while I do find it useful I'd like to reference dtr-org/unit-e-project#40

I do find it important that we follow up to stale issues and pull requests. Maybe we can have something like the "state of the repo" report in bitcoin: bitcoin/bitcoin#15180 – just that it should not just track code changes but also issues, pull requests, response times, things like that.

@cornelius
Copy link
Member Author

I do find it important that we follow up to stale issues and pull requests. Maybe we can have something like the "state of the repo" report in bitcoin: bitcoin/bitcoin#15180 – just that it should not just track code changes but also issues, pull requests, response times, things like that.

I agree with that. Having some reports to not lose sight on stale issues etc. is important, I think. A more passive solution like the "state of the repo" report probably is more practical because it happens so easily that you tune out of notifications if they are too frequent.

I would suggest to follow up on how to address stale issues and pull requests as part of dtr-org/unit-e-project#40.

@scravy scravy changed the title Switch off Mergeable's messages on stale issues and pull requests Switch off Mergeable's reminders on stale issues and pull requests Jan 21, 2019
@scravy scravy merged commit 1f119c4 into dtr-org:master Jan 21, 2019
@cornelius cornelius deleted the mergeable branch February 6, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo Configuration of the repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants