Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes April 2020 #109

Merged
merged 4 commits into from
Apr 22, 2020
Merged

Bugfixes April 2020 #109

merged 4 commits into from
Apr 22, 2020

Conversation

BSchilperoort
Copy link
Collaborator

Fixes #104, #105, #107

  • Re-adds the _sections attribute when calling datastore.sections if it is missing.
  • Obtains attributes from dataset when creating a datastore from a dataset
  • shift_double_ended can be silenced (no print to console)
  • Check if variance kwargs are passed to calibration_double_ended for the wls calibration. Return a clear error if they are missing.

@bdestombe
Copy link
Collaborator

Great Bart!
It fails travisCI though.. But it has nothing to do with your changes. Sphinx updated its API in version 3.0.0, and causes troubles to one of its unmaintained plugins. I'd guess for the same reason as described here: pcdshub/pcdsdevices#410 .

Let's merge this PR and create a new issue/PR for the Sphinx problem. The documentation won't be updated until the Sphinx problem is fixed.

Copy link
Collaborator

@bdestombe bdestombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #109 into master will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   74.18%   74.18%   -0.01%     
==========================================
  Files           8        8              
  Lines        3138     3145       +7     
  Branches      672      677       +5     
==========================================
+ Hits         2328     2333       +5     
- Misses        601      602       +1     
- Partials      209      210       +1     
Impacted Files Coverage Δ
src/dtscalibration/datastore.py 76.14% <75.00%> (-0.03%) ⬇️
src/dtscalibration/datastore_utils.py 89.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc71888...6c96ac6. Read the comment docs.

@BSchilperoort BSchilperoort merged commit 4b0d784 into master Apr 22, 2020
@BSchilperoort BSchilperoort deleted the bugfixes_april2020 branch April 22, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

shift_double_ended throws away unexpected data variables
2 participants