minor fixes

duckdb · Oct 25, 2024 · cc4eea6 · cc4eea6
1 parent 1261ea9
commit cc4eea6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/benchmark/benchmark.Makefile b/benchmark/benchmark.Makefile
@@ -35,7 +35,7 @@ bench-run-tpch-sf1-parquet: bench-output-dir
 bench-run-tpch-sf1-duckdb: bench-output-dir
 	./build/release/benchmark/benchmark_runner --root-dir './' 'benchmark/tpch/sf1/local/duckdb/$(BENCHMARK_PATTERN)' 2>&1 | tee benchmark_results/tpch-sf1-duckdb.csv
 # COMPARES TPCH SF1 on parquet file vs on delta files vs on duckdb files
-bench-run-tpch-sf1: bench-run-tpch-sf1-delta bench-run-tpch-sf1-parquet bench-run-tpch-sf1-attach
+bench-run-tpch-sf1: bench-run-tpch-sf1-delta bench-run-tpch-sf1-parquet bench-run-tpch-sf1-delta-attach
 
 ###
 # TPCDS

diff --git a/duckdb b/duckdb
diff --git a/src/storage/delta_catalog.cpp b/src/storage/delta_catalog.cpp
@@ -71,8 +71,7 @@ optional_idx DeltaCatalog::GetCatalogVersion(ClientContext &context) {
         return delta_transaction.table_entry->snapshot->version;
     }
 
-    // FIXME: this is not allowed
-    return optional_idx::Invalid();
+    return {};
 }
 
 DatabaseSize DeltaCatalog::GetDatabaseSize(ClientContext &context) {
+5 −4		extension/parquet/column_reader.cpp
+2 −1		extension/parquet/include/column_reader.hpp
+13 −0		src/include/duckdb.h
+2 −0		src/include/duckdb/main/capi/extension_api.hpp
+2 −1		src/include/duckdb/main/capi/header_generation/apis/v0/dev/dev.json
+22 −0		src/include/duckdb/main/capi/header_generation/functions/prepared_statements.json
+2 −0		src/include/duckdb_extension.h
+17 −4		src/main/capi/prepared-c.cpp