Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest kernel version (patch no longer needed) #13

Merged
merged 1 commit into from
May 27, 2024

Conversation

nicklan
Copy link
Contributor

@nicklan nicklan commented May 24, 2024

This does a few things:

  1. update the version of kernel to use
  2. update the types to match the new names in kernel
  3. remove the s3 patch. kernel now has a feature (cloud) that will enable this, and since this builds with --all-features it will be enabled

@samansmink, by default this won't build in debug mode. it fails with:

duckdb_delta/duckdb/src/include/duckdb/common/helper.hpp:242:57: error: cannot ‘dynamic_cast’ ‘source’ (of type ‘const struct duckdb::MultiFileReaderGlobalState*’) to type ‘const struct duckdb::DeltaMultiFileReaderGlobalState*’ (source type is not polymorphic)
  242 |         D_ASSERT(reinterpret_cast<const T *>(source) == dynamic_cast<const T *>(source));

it builds fine in release mode.

my c++ foo is good enough to fix this by adding:

        virtual ~MultiFileReaderGlobalState() {}

to that class, but not good enough to know if that's the correct fix or if something I've done here has broken things.

@samansmink
Copy link
Collaborator

looks good, thanks!

@samansmink samansmink merged commit dc00b19 into duckdb:main May 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants