Fix "too many open files" #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scovich
reviewed
Jun 3, 2024
| @@ -57,16 +57,21 @@ struct DeltaSnapshot : public MultiFileList { | |||
| // TODO: How to guarantee we only call this after the filter pushdown? | |||
| void InitializeFiles(); | |||
|
|
|||
| template <class T> | |||
| T TryUnpackKernelResult(ffi::ExternResult<T> result) { | |||
| return KernelUtils::UnpackResult<T>(result, StringUtil::Format("While trying to read from delta table: '%s'", paths[0])); | |||
There was a problem hiding this comment.
Might be better for UnpackResult to accept a lambda, to avoid allocating a string on the happy path of every kernel call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel pointers were not properly freed.
Fixed by wrapping everything kernel in the UniqueKernelPointers. Refactored the utils a little in the process