Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc fix related to node-api docs #75

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

freakynit
Copy link
Contributor

Specifically this part:

Read chunk data (row-major):
const columns = chunk.getRows(); 

^ Variable name should be rows, not columns.

Specifically this part:
```
Read chunk data (row-major):
const columns = chunk.getRows(); 
```
^ Variable name should be `rows` not columns.
Copy link
Contributor

@jraymakers jraymakers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Thanks for the fixes!

@jraymakers jraymakers merged commit c8dd39f into duckdb:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants