disconnect #78
Merged
disconnect #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
connection.disconnect()(and the synonymconnection.close()).The challenge was dealing with the automatic disconnect during finalization and also double-disconnect. To make this work I had to add another layer of indirection around the connection object, so it can be nulled out. Luckily this wasn't too bad.
Added some error handling with helpful exception messages for trying to do things (query, prepare, etc.) on a disconnected connection. Some C API functions don't initialize their out parameters in some error conditions, so I added some defense-in-depth against that. Added several unit tests, at both the bindings and api layers.