Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor DuckDB sources, bumping to duckdb's version v0.10.1 #68

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

carlopi
Copy link
Collaborator

@carlopi carlopi commented Mar 18, 2024

No description provided.

@carlopi
Copy link
Collaborator Author

carlopi commented Mar 21, 2024

Update: something is off with the vendor.py script, but I was too lazy to properly debug this.

Documenting the workaround (that should probably directly added to CI):

cd ..
git clone https://github.com/duckdb/duckdb.git --branch vX.Y.Z fresh_duckdb
cd duckdb-node
./vendor --duckdb ../fresh_duckdb
git add *
git commit -m "Vendor DuckDB vX.Y.Z"

@carlopi
Copy link
Collaborator Author

carlopi commented Mar 21, 2024

Also, I need to generate the results for test_all_types's new types.

For now EXCLUDED them from testing, that should make this already mergeable.

@hannes hannes merged commit f9a910d into duckdb:main Mar 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants