-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reusable workflows for deploying nightly binaries #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks great. One minor comment. For the organization secrets, perhaps @hannes can have a look?
I'll chat with hannes today on this |
Thanks for the updates - is this ready to merge? |
yea think so! |
Thanks! |
This PR adds the reusable workflow for extension deployment to the postgress scanner, which allows producing nightly binaries. In the process, I removed the workflows that would be duplicates, leaving only the linux job that would actually run the tests with the postgres server. Also i added a require-env to all tests because the reusable workflow will call
make test
@Mytherin Before merging we need to add the s3 credentials and signing token to the repo. Maybe we can add them as an organisation secret?