Add more options for opening SQLite databases - busy_timeout and journal_mode - and set busy time-out by default #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
breckcs
pushed a commit
to breckcs/duckdb_sqlite_scanner_concurrency_tests
that referenced
this pull request
Mar 22, 2024
- Updated duckdb-rs to v0.10.1 to include the fix for duckdb/duckdb-sqlite#82 - Added JOURNAL_MODE 'WAL' when DuckDB attaches the SQLite database as documented in duckdb/duckdb-sqlite#83 - These two changes, however, did not seem to fix the concurrency errors documented in duckdb/duckdb-sqlite#82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
This PR adds two new settings when attaching SQLite databases -
busy_timeoutandjournal_mode.busy_timeoutspecifies a busy timeout in milliseconds, see here. This refers to the amount of time the process will wait if there is another process operating on the SQLite file. The default is now set to 5 seconds (i.e.BUSY_TIMEOUT = 5000), which is the same default used by rusqlite.journal_modespecifies a journaling mode, e.g.journal_modecan beWAL. See here for more info.Usage:
This fixes the linked issue by specifying a busy time-out by default which prevents
database is lockederrors from appearing until after the timeout has passed. To restore previous behavior where the system would immediately returndatabase is lockedabusy_timeoutof 0 can be specified.