-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support AWS SSO authentication #49
Conversation
full disclaimer: I did not try this out, looks good though. Thanks! |
I've been using it locally and it works fine. I'm not sure if you need/want the docs updated? You have to run |
Thanks a lot for this! I was pulling my hair out, trying to figure out why it wasn't working 😄 Do you expect this to be included in the next release, pending 2nd of September? |
@aksel yes, but you can already try this out on duckdb v1.0.0 by switching to the nightly build of |
Cool, thanks a lot! |
Hey! I seem to still be facing this issue with the SSO chain on Sequence of commands I am running after I
Still, the output of secret_string is:
Using the
I did manage to do the same setup, with nightly aws extension, on a Any help? Am I missing something? |
I've been meaning to come back to this as well, I've noticed that using the nightly version of the AWS plugin isn't working with SSO still. I don't quite understand why not, because the version that I compiled locally definitely did! I haven't had a chance to do any investigation yet, though :( |
@drmorr0 thanks for your help! Confirming it's not just me already rules out other issues at least. For now I think I can make due with the |
The aws extension doesn't correctly work with the
sso
credential provider, as noted in a comment in #31 (and possibly also #42? It's unclear in that report which credential provider the user is using). As noted in PR #45, theaws-sdk-cpp
library needs to include thests
feature for that credential provider to work; similarly, it needs thesso
feature for this provider to work.I've confirmed that my change fixes the behaviour (at least for me):
I tried to look at the other credential providers that duckdb_aws (claims to) provide in the docs: afaict,
config
andenv
work now.sts
was fixed (I believe) by #45, and this PR should fixsso
. I "assume" thatprocess
works correctly, so the only one I'm not sure about isinstance
but this is just hitting the instance metadata store on an EC2 instance so I feel like it "should" work? The web identity token method described in #16 and #31 maybe just requires some otheraws-sdk-cpp
feature to be enabled, but I'm not really sure which one and don't have a good way to test that in any case.Hope this is helpful!