-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable rust, fix ubuntu 18 failure #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SION to enable rust builds
samansmink
force-pushed
the
re-enable-rust-building
branch
from
July 11, 2024 13:44
f3482f8
to
4d1e569
Compare
samansmink
changed the title
Re enable rust building
Re-enable rust, fix ubuntu 18 failure
Jul 11, 2024
carlopi
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore rust-based extension builds
restores building rust-based extensions by reverting the changes from #42 in favor of setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
We should properly fix this asap as ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION could be removed at any time.
Add CI job to test PRs to this repo
This PR also adds a CI job to test this repo by building https://github.com/duckdb/extension-template and https://github.com/duckdb/duckdb_delta using this version of the ci tools.
Fixes ubuntu 18 failures
Fixes failures like this:
in the ubuntu18 setup script by completely removing that. In the process I stripped various other things that are old and unused.
Future work
Re-enable the fix from Unroll logic out of github action and into docker + script #42 in a cleaner way which support rust builds.
Further clean up the Linux based CI. As Ubuntu18 and manylinux2014 are getting long in the tooth, we should move towards a setup where we are less likely to suffer from breakage as github architectures. All linux builds should likely just manually run the build inside docker container then upload the artifacts outside of docker