Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable rust, fix ubuntu 18 failure #50

Merged
merged 14 commits into from
Jul 11, 2024

Conversation

samansmink
Copy link
Collaborator

@samansmink samansmink commented Jul 11, 2024

restore rust-based extension builds

restores building rust-based extensions by reverting the changes from #42 in favor of setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

We should properly fix this asap as ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION could be removed at any time.

Add CI job to test PRs to this repo

This PR also adds a CI job to test this repo by building https://github.com/duckdb/extension-template and https://github.com/duckdb/duckdb_delta using this version of the ci tools.

Fixes ubuntu 18 failures

Fixes failures like this:

There’s nothing that PPA owners can do about this for now, as the key is fully controlled internally by Launchpad.
 More info: https://launchpad.net/~git-core/+archive/ubuntu/ppa
Error: retrieving gpg key timed out.

in the ubuntu18 setup script by completely removing that. In the process I stripped various other things that are old and unused.

Future work

  • Re-enable the fix from Unroll logic out of github action and into docker + script #42 in a cleaner way which support rust builds.

  • Further clean up the Linux based CI. As Ubuntu18 and manylinux2014 are getting long in the tooth, we should move towards a setup where we are less likely to suffer from breakage as github architectures. All linux builds should likely just manually run the build inside docker container then upload the artifacts outside of docker

@samansmink samansmink force-pushed the re-enable-rust-building branch from f3482f8 to 4d1e569 Compare July 11, 2024 13:44
@samansmink samansmink changed the title Re enable rust building Re-enable rust, fix ubuntu 18 failure Jul 11, 2024
Copy link
Collaborator

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@samansmink
Copy link
Collaborator Author

failure is unrelated

@samansmink samansmink merged commit b9b4693 into duckdb:main Jul 11, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants