Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split makefile to move it upstream #60

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

samansmink
Copy link
Collaborator

@samansmink samansmink commented Feb 28, 2024

The goal is to pull out-of-tree-extension.Makefile up into the duckdb repo.

That way we can just add flags and options upstream and all out-of-tree repo's will be updated.

Note that I added some vars to configure the makefile

# Inputs
#   EXT_NAME          : Upper case string describing the name of the out-of-tree extension
#   EXT_CONFIG        : Path to the extension config file specifying how to build the extension
#   EXT_FLAGS         : Extra CMake flags to pass to the build
#   EXT_RELEASE_FLAGS : Extra CMake flags to pass to the release build
#   EXT_DEBUG_FLAGS   : Extra CMake flags to pass to the debug build

Thoughts? anything missing?

Edit: oh I also remove the client tests

@samansmink samansmink marked this pull request as ready for review February 29, 2024 12:40
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense to me!

@samansmink samansmink merged commit 31ad3a8 into duckdb:main Mar 5, 2024
25 checks passed
@samansmink samansmink deleted the split-makefile branch March 5, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants