Add SQL scalar and table macros and tests #84
Conversation
|
Howdy @carlopi and @samansmink ! Would you be able to give this a review in the next week? I'd love to merge this before blogging about it, and I'm aiming for next Friday (9/27) to publish. Cheers! |
There was a problem hiding this comment.
Hey Alex! Thanks for the PR! I think SQL-only extensions are a great idea, looking forward to the blogpost.
I do feel this might bloat the extension template a little bit in its current state. I feel the extension template should remain as few lines as possible. Any documentation or examples of building extensions should go elsewhere I feel. If we start adding more an more examples to it I feel we can confuse people cloning the template.
happy to discuss this though if you or @carlopi disagree
|
Ok! Mind if I make a second template just for SQL then? I can strip it way down (removing the C++ examples). |
|
I also reworked this to be as few lines as possible in case it is helpful. Does this make it easier to merge? I also moved everything to the bottom (of both the .cpp file and the tests). If I make another template (let me know if that sounds ok!), would you like for it to be one of my repos or a duckdb repo? |
|
Howdy @carlopi and @samansmink - thanks for taking a look! I'd like to publish the blog tomorrow and I think I have 2 options:
In the future, there could be an option 3:
Which option should we go with? Thanks! |
|
Hi @Alex-Monahan, this was on me, sorry for being late. I would say moving this to sql-only-duckdb-extension, possibly moving already that today/tomorrow with the duckdb org. I would also file that as part of the community extension, I think it does make sense to have also templates there. I think a cool idea would also be:
Advantages of this is saying to people: you just modify this JSON file, run the python script (that performs some checks, possibly), and that's basically it. JSON file (or whatever the format) can also have additional fields backed in like examples / comments / what not, but then only the needed ones are used. This could work both with C++-based extensions but later switch transparently to C-API-only extensions. |
|
Sounds good! I think moving to another format could work great. The stretch goal I have is to actually allow folks to just paste in their create macro statements and then parse them into the format that C++ needs. So I think we could even just use a .sql file as the input. For another day! :-) The sql-only-duckdb-extension repo is fixed and up to date now I believe. It looks like somehow I have the power to create a new repo within the DuckDB org. |
Hi folks!
This adds support for SQL scalar and table macros to the extension template.
I am super open to feedback - I added a big comment block within the .cpp file since our audience for this is SQL folks without C++ knowledge. If you would prefer to see it in a README or elsewhere, just let me know and I can move/adjust.
The goal is to publish the SQL-only extension blog post that relies on this feature by next Friday 2024-09-27
this Friday, 2024-09-20, but I don't think we have anything on the blog schedule for the following week. I am flexible!@szarnyasg as an FYI since this is related to the upcoming blog!
As a note, this is also dependent on a 1.1.0 feature, so it is not backward compatible with 1.0.0. However, the supported versions table did not include 1.0.0, so I felt comfortable doing it this way!