Merge pull request #38 from hydradatabase/propagate_execution_error

Check for error and report the error on the result of `quackScanState->preparedStatement->Execute()`

src/quack_node.cpp

@@ -62,6 +62,10 @@ Quack_ExecCustomScan(CustomScanState *node) {
 		quackScanState->is_executed = true;
 	}
 
+	if (quackScanState->queryResult->HasError()) {
+		elog(ERROR, "Quack execute returned an error: %s", quackScanState->queryResult->GetError().c_str());
+	}
+
 	if (quackScanState->fetch_next) {
 		quackScanState->currentDataChunk = quackScanState->queryResult->Fetch();
 		quackScanState->currentRow = 0;

test/regression/expected/execution_error.out

@@ -0,0 +1,9 @@
+create table int_as_varchar(a varchar);
+insert into int_as_varchar SELECT * from (
+	VALUES
+		('abc')
+) t(a);
+select a::INTEGER from int_as_varchar;
+ERROR:  Quack execute returned an error: Conversion Error: Could not convert string 'abc' to INT32
+LINE 1: select a::INTEGER from int_as_varchar;
+                ^

test/regression/schedule

@@ -1,3 +1,4 @@
 test: basic
 test: search_path
+test: execution_error
 test: type_support

test/regression/sql/execution_error.sql

@@ -0,0 +1,7 @@
+create table int_as_varchar(a varchar);
+insert into int_as_varchar SELECT * from (
+	VALUES
+		('abc')
+) t(a);
+
+select a::INTEGER from int_as_varchar;