-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for REGCLASSOID
type
#108
Conversation
Could you please add a test case for this type? Once that's done, lgtm! |
default: | ||
return duckdb::LogicalType::USER("UnsupportedPostgresType"); | ||
case REGCLASSOID: | ||
return duckdb::LogicalTypeId::INTEGER; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works, do keep in mind that this means we lose the context of what this was on the postgres side this way.
We'd need something similar to what we do for NumericAsDouble
to differentiate between an actual INT4 and a REGCLASSOID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah definitely. I added this because it was useful for me debugging internals but agree that we're losing information here.
OIDs are unsigned, so this goes wrong:
|
Thanks for catching this! I'll work on this ASAP |
Will be fixed here: #125 |
Small QoL PR that does two minor thing:
REGCLASSOID
type