Read cache metadata correctly #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we will not be able to read cache metadata for files that are bigger than 4GB because we use stoi function. Use stoll instead that will read long long values.
Y--
approved these changes
Dec 16, 2024
Y--
reviewed
Dec 16, 2024
| @@ -264,7 +264,7 @@ DuckdbGetCachedFilesInfos() { | |||
| p.path().c_str()); | |||
| break; | |||
| } | |||
| cache_info.push_back(CacheFileInfo {metadata_tokens[0], metadata_tokens[1], std::stoi(metadata_tokens[2]), | |||
| cache_info.push_back(CacheFileInfo {metadata_tokens[0], metadata_tokens[1], std::stoll(metadata_tokens[2]), | |||
There was a problem hiding this comment.
Timestamp is also a int64 - we should also stoll(metadata_tokens[3])
mkaruza
changed the title
Y--
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we will not be able to read cache metadata for files that are bigger than 4GB because we use stoi function. Use stoll instead that will read long long values. Timestamp also needs to be read with stoll.