Bump clang-format and ruff versions to latest #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
force-pushed
the
bump-formatting-tools
branch
from
4dc7f70 to
5a9a1bd
Compare
Y--
approved these changes
Dec 16, 2024
| DefineCustomVariable("duckdb.autoload_known_extensions", | ||
| "Whether known extensions are allowed to be automatically loaded when a DuckDB query depends on them", | ||
| &duckdb_autoload_known_extensions, PGC_SUSET); | ||
| DefineCustomVariable( |
There was a problem hiding this comment.
Interesting that the other in this file weren't changed?
There was a problem hiding this comment.
agreed, I guess the description was not long enough. Probably we want to tweak the clang-format settings to format these consistently, but let's save that for a follow up PR.
JelteF
added a commit
that referenced
this pull request
Dec 20, 2024
In #496 I failed to include the `.hpp` in my clang-format run. This does that too, and updates our `format-all` rule accordingly.
JelteF
added a commit
that referenced
this pull request
Dec 20, 2024
In #496 I failed to include the `.hpp` in my clang-format run. This does that too, and updates our `format-all` rule accordingly.
JelteF
added a commit
that referenced
this pull request
Jan 3, 2025
In #496 we started using the newest clang-format to format our files, but CI was still installing the old version. This meant that we were not catching some unformatted files correctly. An example of this being: #511 (comment) This starts using the correct clang-format version in CI too and formats any incorrectly formatted files.
Y--
pushed a commit
that referenced
this pull request
Jan 6, 2025
In #496 we started using the newest clang-format to format our files, but CI was still installing the old version. This meant that we were not catching some unformatted files correctly. An example of this being: #511 (comment) This starts using the correct clang-format version in CI too and formats any incorrectly formatted files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #98 we started using the same version of clang-format that DuckDB uses. That version is pretty ancient though. So it misses a bunch of features that we might want to use, and also has a bunch of bugs which result in sub-optimal formatting. This updates
clang-formatto the latest version, and while we're at it we also updateruff.To be able to reformat all existing files, this also adds a
format-alltarget to ourMakefile.The problem was called out by @dpxcc in #493, but I've been also running into this myself for a while.