Support approx_count_distinct #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Dec 18, 2024
sql/pg_duckdb--0.2.0--0.3.0.sql
Outdated
| @@ -0,0 +1,9 @@ | |||
| CREATE FUNCTION @[email protected]_count_distinct(a anyelement) | |||
There was a problem hiding this comment.
This should no be added as a function, but as a function but as an aggregate. Currently the following query fails on your test schema because of that:
> SELECT approx_count_distinct(a) FROM t group by b;
ERROR: 42803: column "t.a" must appear in the GROUP BY clause or be used in an aggregate function
LINE 1: SELECT approx_count_distinct(a) FROM t group by b;
There was a problem hiding this comment.
Thanks for the catch!!
JelteF
reviewed
Dec 18, 2024
sql/pg_duckdb--0.2.0--0.3.0.sql
Outdated
| @@ -0,0 +1,9 @@ | |||
| CREATE FUNCTION @[email protected]_count_distinct(a anyelement) | |||
There was a problem hiding this comment.
I'm wondering if this should be created in @extschema@ (i.e. the public schema) or the duckdb schema. I think @extschema@ is probably fine.
There was a problem hiding this comment.
I don't have a strong opinion. I was just following the existing functions
dpxcc
force-pushed
the
cc
branch
2 times, most recently
from
5a816ad to
70231b2
Compare
|
Change |
dpxcc
force-pushed
the
cc
branch
2 times, most recently
from
2352ea2 to
3d4f730
Compare
|
@JelteF Could you please take a look again? Thanks! |
JelteF
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
approx_count_distinct()