Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load icu extension by default #512

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Load icu extension by default #512

merged 5 commits into from
Jan 2, 2025

Conversation

ritwizsinha
Copy link
Contributor

@ritwizsinha ritwizsinha commented Dec 23, 2024

Fixes comparisons/operators of the timestamp with timezone type.

Fixes #490

@mkaruza mkaruza self-requested a review December 23, 2024 15:47
@mkaruza
Copy link
Collaborator

mkaruza commented Dec 23, 2024

Hi @ritwizsinha thank you for PR. Could we add test to check why icu will fix #490 before me do merge?
Also could you fix current failing test.

@ritwizsinha
Copy link
Contributor Author

@mkaruza done

@mkaruza mkaruza self-requested a review December 23, 2024 20:10
test/regression/sql/timestamp_with_interval.sql Outdated Show resolved Hide resolved
@JelteF JelteF enabled auto-merge (squash) January 2, 2025 13:05
@JelteF JelteF disabled auto-merge January 2, 2025 13:05
@JelteF JelteF enabled auto-merge (squash) January 2, 2025 13:06
@JelteF JelteF dismissed mkaruza’s stale review January 2, 2025 13:49

test was added

@JelteF JelteF merged commit 1a68605 into duckdb:main Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain queries with (TIMESTAMPTZ + INTERVAL) operation fail
3 participants