Skip to content

Commit

Permalink
Fix: Don't show the find-in-page bar if it's hidden (#5381)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1207418217763355/1205772199506591/f

### Description

This fix prevents showing the find-in-page bar when changing the omnibar
position.

### Steps to test this PR

- [x] Go to any URL
- [x] Perform a find in page search for any text
- [x] Dismiss the find in page bar
- [x] Go into settings & switch omnibar to the opposite position
- [x] Notice the find in page toolbar is not visible
- [x] Switch the omnibar position again
  • Loading branch information
0nko authored Dec 11, 2024
1 parent 67690c0 commit 15ab4b7
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,7 @@ class Omnibar(
binding.focusDummy.requestFocus()
findInPage.findInPageContainer.gone()
findInPage.findInPageInput.hideKeyboard()
findInPage.findInPageInput.text.clear()
}
}

Expand Down

0 comments on commit 15ab4b7

Please sign in to comment.