Skip to content

Commit

Permalink
Fix fire button ripple (#4922)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/488551667048375/1208089433074776/f

### Description
Fixes the ripple on the fire button which clipped on the left side.

### Steps to test this PR

- [x] Tap and hold the fire button
- [x] Verify that the ripple isn’t clipped

### UI changes
| Before  | After |
| ------ | ----- |

![Screenshot_20240820_185353](https://github.com/user-attachments/assets/7b528234-558d-4b1c-98a4-2ab1623794a4)|![Screenshot_20240820_184445](https://github.com/user-attachments/assets/a8c17c1b-a758-4341-b1e3-1199762cdd3d)
  • Loading branch information
joshliebe authored Aug 20, 2024
1 parent 8141ee1 commit 1e4d172
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions app/src/main/res/layout/include_omnibar_toolbar.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@
android:id="@+id/omniBarContainer"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_margin="8dp"
android:layout_marginStart="8dp"
android:layout_marginEnd="4dp"
android:layout_marginTop="8dp"
android:layout_marginBottom="8dp"
android:paddingEnd="6dp"
android:background="@drawable/omnibar_field_selector">

Expand Down Expand Up @@ -242,7 +245,7 @@
android:id="@+id/fireIconMenu"
android:layout_width="wrap_content"
android:layout_height="match_parent"
android:paddingStart="4dp"
android:paddingStart="8dp"
android:paddingEnd="4dp"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@id/tabsMenu"
Expand Down

0 comments on commit 1e4d172

Please sign in to comment.