switch to true|false for protectionsState param (#3838)

Task/Issue URL: https://app.asana.com/0/0/1205915950517978/f ### Description Switching to true|false instead of 1|0 for cross-platform consistency. See the parent task https://app.asana.com/0/1201141132935289/1205644489547731 ### Steps to test this PR - [x] Submit the breakage form with protections on - [x] Verify that the breakage form pixel param `protectionsState` is the string `true` - [x] Submit the breakage form with protections off - [x] Verify that the breakage form pixel param `protectionsState` is the string `false`
duckduckgo · Nov 9, 2023 · 5939b1c · 5939b1c
1 parent 5ac9d51
commit 5939b1c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/app/src/main/java/com/duckduckgo/app/brokensite/api/BrokenSiteSender.kt b/app/src/main/java/com/duckduckgo/app/brokensite/api/BrokenSiteSender.kt
@@ -100,7 +100,7 @@ class BrokenSiteSubmitter @Inject constructor(
                 REMOTE_CONFIG_ETAG to privacyConfig.privacyConfigData()?.eTag.orEmpty(),
                 ERROR_CODES_KEY to brokenSite.errorCodes,
                 HTTP_ERROR_CODES_KEY to brokenSite.httpErrorCodes,
-                PROTECTIONS_STATE to protectionsState.toBinaryString(),
+                PROTECTIONS_STATE to protectionsState.toString(),
             )
 
             val lastSentDay = brokenSiteLastSentReport.getLastSentDay(domain.orEmpty())

diff --git a/app/src/test/java/com/duckduckgo/app/brokensite/api/BrokenSiteSubmitterTest.kt b/app/src/test/java/com/duckduckgo/app/brokensite/api/BrokenSiteSubmitterTest.kt
@@ -116,7 +116,7 @@ class BrokenSiteSubmitterTest {
         verify(mockPixel).fire(eq(BROKEN_SITE_REPORT.pixelName), paramsCaptor.capture(), encodedParamsCaptor.capture())
         val params = paramsCaptor.firstValue
 
-        assertEquals("0", params["protectionsState"])
+        assertEquals("false", params["protectionsState"])
     }
 
     @Test
@@ -133,7 +133,7 @@ class BrokenSiteSubmitterTest {
         verify(mockPixel).fire(eq(BROKEN_SITE_REPORT.pixelName), paramsCaptor.capture(), encodedParamsCaptor.capture())
         val params = paramsCaptor.firstValue
 
-        assertEquals("0", params["protectionsState"])
+        assertEquals("false", params["protectionsState"])
     }
 
     @Test
@@ -150,7 +150,7 @@ class BrokenSiteSubmitterTest {
         verify(mockPixel).fire(eq(BROKEN_SITE_REPORT.pixelName), paramsCaptor.capture(), encodedParamsCaptor.capture())
         val params = paramsCaptor.firstValue
 
-        assertEquals("0", params["protectionsState"])
+        assertEquals("false", params["protectionsState"])
     }
 
     @Test
@@ -169,7 +169,7 @@ class BrokenSiteSubmitterTest {
         verify(mockPixel).fire(eq(BROKEN_SITE_REPORT.pixelName), paramsCaptor.capture(), encodedParamsCaptor.capture())
         val params = paramsCaptor.firstValue
 
-        assertEquals("0", params["protectionsState"])
+        assertEquals("false", params["protectionsState"])
     }
 
     @Test
@@ -186,7 +186,7 @@ class BrokenSiteSubmitterTest {
         verify(mockPixel).fire(eq(BROKEN_SITE_REPORT.pixelName), paramsCaptor.capture(), encodedParamsCaptor.capture())
         val params = paramsCaptor.firstValue
 
-        assertEquals("1", params["protectionsState"])
+        assertEquals("true", params["protectionsState"])
     }
 
     @Test