Skip to content

Commit

Permalink
passing the credentials file directly in the lane
Browse files Browse the repository at this point in the history
  • Loading branch information
malmstein committed Oct 31, 2024
1 parent 85f4f5a commit 5b49ffa
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/release_production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ on:

env:
ASANA_PAT: ${{ secrets.GH_ASANA_SECRET }}
GOOGLE_APPLICATION_CREDENTIALS: $HOME/jenkins_static/com.duckduckgo.mobile.android/ddg-upload-firebase.json

jobs:
create-tag:
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Appfile
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
json_key_file("~/jenkins_static/com.duckduckgo.mobile.android/api.json") # Path to the json secret file - Follow https://docs.fastlane.tools/actions/supply/#setup to get one
package_name("com.duckduckgo.mobile.android") # e.g. com.krausefx.app
package_name("com.duckduckgo.mobile.android") # e.g. com.krausefx.app
5 changes: 4 additions & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
releaseNotesBodyHeader = "What's new:"
releaseNotesFileBody = "../app/version/release-notes"
appVersionFilePath = "../app/version/version-properties"
firebaseFilePath = "#{ENV["HOME"]}/jenkins_static/com.duckduckgo.mobile.android/ddg-upload-firebase.json"
releaseNotesLocales= ["en-US", "en-GB", "en-CA"]
releaseNotesMaxLength = 500
errorMessageCancelled = "Release cancelled 😢"
Expand Down Expand Up @@ -173,6 +174,7 @@ platform :android do
lane :deploy_dogfood do |options|

UI.message("Aab path: #{options[:aab_path]}")

upload_to_play_store(
aab: options[:aab_path],
track: 'internal',
Expand All @@ -193,7 +195,8 @@ platform :android do
app: "1:239339218528:android:732e03dcf13d1488db8505",
groups: "ddg-employees",
android_artifact_type: "APK",
android_artifact_path: apkPath
android_artifact_path: apkPath,
service_credentials_file: firebaseFilePath,
)

end
Expand Down

0 comments on commit 5b49ffa

Please sign in to comment.