-
Notifications
You must be signed in to change notification settings - Fork 921
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208719691317744/f ### Description This PR moves the Location permission logic to the SitePermissionsManager Note: This ### Steps to test this PR _Location permission granted_ - [x] Fresh install and visit permission.site - [x] Ask for Location permissions - [x] Verify new Location dialog appears - [x] Allow permissions - [x] Verify system dialog is shown - [x] Allow permissions - [x] Verify location is granted (location button is green) _Location permission not granted_ - [x] Fresh install and visit permission.site - [x] Ask for Location permissions - [x] Verify new Location dialog appears - [x] Deny permissions - [x] Verify location is not granted (location button is red) _Location permission granted (not system granted)_ - [x] Fresh install and visit permission.site - [x] Ask for Location permissions - [x] Verify new Location dialog appears - [x] Allow permissions - [x] Verify system dialog is shown - [x] Deny permissions - [x] Verify location is not granted (location button is red) - [x] Verify Snackbar appears - [x] Ask for Location permissions - [x] Verify system dialog is shown - [x] Deny permissions - [x] Verify Settings dialog appears - [x] Tap on Open Settings - [x] Verify Device Settings screen opens --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208719691317744
- Loading branch information
Showing
42 changed files
with
1,006 additions
and
1,041 deletions.
There are no files selected for viewing
397 changes: 14 additions & 383 deletions
397
app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.