Address comments

duckduckgo · Oct 23, 2024 · a064819 · a064819
1 parent f9d7a42
commit a064819
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/...impl/src/main/java/com/duckduckgo/networkprotection/impl/autoexclude/AutoExcludePrompt.kt b/...impl/src/main/java/com/duckduckgo/networkprotection/impl/autoexclude/AutoExcludePrompt.kt
@@ -18,7 +18,7 @@ package com.duckduckgo.networkprotection.impl.autoexclude
 
 import com.duckduckgo.di.scopes.ActivityScope
 import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludePrompt.Trigger
-import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludePrompt.Trigger.NEW_FLAGGED_APP
+import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludePrompt.Trigger.NEW_INCOMPATIBLE_APP_FOUND
 import com.duckduckgo.networkprotection.store.NetPExclusionListRepository
 import com.squareup.anvil.annotations.ContributesBinding
 import javax.inject.Inject
@@ -27,7 +27,7 @@ interface AutoExcludePrompt {
     suspend fun getAppsForPrompt(trigger: Trigger): List<VpnIncompatibleApp>
 
     enum class Trigger {
-        NEW_FLAGGED_APP,
+        NEW_INCOMPATIBLE_APP_FOUND,
         INCOMPATIBLE_APP_MANUALLY_EXCLUDED,
     }
 }
@@ -38,7 +38,7 @@ class RealAutoExcludePrompt @Inject constructor(
     private val autoExcludeAppsRepository: AutoExcludeAppsRepository,
 ) : AutoExcludePrompt {
     override suspend fun getAppsForPrompt(trigger: Trigger): List<VpnIncompatibleApp> {
-        return if (trigger == NEW_FLAGGED_APP) {
+        return if (trigger == NEW_INCOMPATIBLE_APP_FOUND) {
             getFlaggedAppsForPrompt().also {
                 autoExcludeAppsRepository.markAppsAsShown(it)
             }

diff --git a/.../com/duckduckgo/networkprotection/impl/management/NetworkProtectionManagementViewModel.kt b/.../com/duckduckgo/networkprotection/impl/management/NetworkProtectionManagementViewModel.kt
@@ -45,7 +45,7 @@ import com.duckduckgo.networkprotection.api.NetworkProtectionState
 import com.duckduckgo.networkprotection.impl.NetPVpnFeature
 import com.duckduckgo.networkprotection.impl.VpnRemoteFeatures
 import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludePrompt
-import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludePrompt.Trigger.NEW_FLAGGED_APP
+import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludePrompt.Trigger.NEW_INCOMPATIBLE_APP_FOUND
 import com.duckduckgo.networkprotection.impl.autoexclude.VpnIncompatibleApp
 import com.duckduckgo.networkprotection.impl.configuration.WgTunnelConfig
 import com.duckduckgo.networkprotection.impl.configuration.asServerDetails
@@ -194,7 +194,7 @@ class NetworkProtectionManagementViewModel @Inject constructor(
         if (networkProtectionState.isRunning() &&
             !localConfig.autoExcludeBrokenApps().isEnabled()
         ) {
-            autoExcludePrompt.getAppsForPrompt(NEW_FLAGGED_APP).also {
+            autoExcludePrompt.getAppsForPrompt(NEW_INCOMPATIBLE_APP_FOUND).also {
                 if (it.isNotEmpty()) {
                     sendCommand(ShowAutoExcludeDialog(it))
                 }

diff --git a/.../test/java/com/duckduckgo/networkprotection/impl/autoexclude/RealAutoExcludePromptTest.kt b/.../test/java/com/duckduckgo/networkprotection/impl/autoexclude/RealAutoExcludePromptTest.kt
@@ -1,6 +1,6 @@
 package com.duckduckgo.networkprotection.impl.autoexclude
 
-import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludePrompt.Trigger.NEW_FLAGGED_APP
+import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludePrompt.Trigger.NEW_INCOMPATIBLE_APP_FOUND
 import com.duckduckgo.networkprotection.store.NetPExclusionListRepository
 import com.duckduckgo.networkprotection.store.db.NetPManuallyExcludedApp
 import kotlinx.coroutines.test.runTest
@@ -44,7 +44,7 @@ class RealAutoExcludePromptTest {
                 VpnIncompatibleApp("test2"),
             ),
         )
-        val result = autoExcludePrompt.getAppsForPrompt(NEW_FLAGGED_APP)
+        val result = autoExcludePrompt.getAppsForPrompt(NEW_INCOMPATIBLE_APP_FOUND)
 
         assertTrue(result.contains(VpnIncompatibleApp("test1")))
         assertFalse(result.contains(VpnIncompatibleApp("test2")))
@@ -60,7 +60,7 @@ class RealAutoExcludePromptTest {
                 VpnIncompatibleApp("test2"),
             ),
         )
-        val result = autoExcludePrompt.getAppsForPrompt(NEW_FLAGGED_APP)
+        val result = autoExcludePrompt.getAppsForPrompt(NEW_INCOMPATIBLE_APP_FOUND)
 
         assertTrue(result.contains(VpnIncompatibleApp("test1")))
         assertTrue(result.contains(VpnIncompatibleApp("test2")))
@@ -71,7 +71,7 @@ class RealAutoExcludePromptTest {
         whenever(netPExclusionListRepository.getManualAppExclusionList()).thenReturn(emptyList())
         whenever(autoExcludeAppsRepository.getAppsForAutoExcludePrompt()).thenReturn(emptyList())
 
-        val result = autoExcludePrompt.getAppsForPrompt(NEW_FLAGGED_APP)
+        val result = autoExcludePrompt.getAppsForPrompt(NEW_INCOMPATIBLE_APP_FOUND)
 
         assertTrue(result.isEmpty())
     }