Android ANR: com.duckduckgo.app.tabs.ui.TabSwitcherAdapter.loadTabPre…

…viewImage (#5432) Task/Issue URL: https://app.asana.com/0/488551667048375/1209069285792730/f ### Description Moved file operations to background. ### Steps to test this PR - [x] Install from this branch. - [x] Open many tabs and go to the Tab Switcher screen. - [x] Notice the tabs are loaded properly and the app doesn't freeze. ### NO UI changes
duckduckgo · Jan 6, 2025 · ad28ee1 · ad28ee1
1 parent 11dcf5b
commit ad28ee1
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherActivity.kt b/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherActivity.kt
@@ -115,7 +115,7 @@ class TabSwitcherActivity : DuckDuckGoActivity(), TabSwitcherListener, Coroutine
 
     private val viewModel: TabSwitcherViewModel by bindViewModel()
 
-    private val tabsAdapter: TabSwitcherAdapter by lazy { TabSwitcherAdapter(this, webViewPreviewPersister, this, faviconManager) }
+    private val tabsAdapter: TabSwitcherAdapter by lazy { TabSwitcherAdapter(this, webViewPreviewPersister, this, faviconManager, dispatchers) }
 
     // we need to scroll to show selected tab, but only if it is the first time loading the tabs.
     private var firstTimeLoadingTabsList = true

diff --git a/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherAdapter.kt b/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherAdapter.kt
@@ -47,17 +47,19 @@ import com.duckduckgo.app.tabs.ui.TabSwitcherAdapter.TabViewHolder
 import com.duckduckgo.app.tabs.ui.TabSwitcherAdapter.TabViewHolder.GridTabViewHolder
 import com.duckduckgo.app.tabs.ui.TabSwitcherAdapter.TabViewHolder.ListTabViewHolder
 import com.duckduckgo.common.ui.view.show
+import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.common.utils.swap
 import java.io.File
-import java.util.Collections.swap
 import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 import timber.log.Timber
 
 class TabSwitcherAdapter(
     private val itemClickListener: TabSwitcherListener,
     private val webViewPreviewPersister: WebViewPreviewPersister,
     private val lifecycleOwner: LifecycleOwner,
     private val faviconManager: FaviconManager,
+    private val dispatchers: DispatcherProvider,
 ) : Adapter<TabViewHolder>() {
 
     private val list = mutableListOf<TabEntity>()
@@ -174,14 +176,23 @@ class TabSwitcherAdapter(
 
     private fun loadTabPreviewImage(tab: TabEntity, glide: RequestManager, holder: GridTabViewHolder) {
         val previewFile = tab.tabPreviewFile ?: return glide.clear(holder.tabPreview)
-        val cachedWebViewPreview = File(webViewPreviewPersister.fullPathForFile(tab.tabId, previewFile))
-        if (!cachedWebViewPreview.exists()) return glide.clear(holder.tabPreview)
 
-        glide.load(cachedWebViewPreview)
-            .transition(DrawableTransitionOptions.withCrossFade())
-            .into(holder.tabPreview)
+        lifecycleOwner.lifecycleScope.launch {
+            val cachedWebViewPreview = withContext(dispatchers.io()) {
+                File(webViewPreviewPersister.fullPathForFile(tab.tabId, previewFile)).takeIf { it.exists() }
+            }
+
+            if (cachedWebViewPreview == null) {
+                glide.clear(holder.tabPreview)
+                return@launch
+            }
+
+            glide.load(cachedWebViewPreview)
+                .transition(DrawableTransitionOptions.withCrossFade())
+                .into(holder.tabPreview)
 
-        holder.tabPreview.show()
+            holder.tabPreview.show()
+        }
     }
 
     private fun attachClickListeners(holder: TabViewHolder, tab: TabEntity) {