Skip to content

Commit

Permalink
Revert "Allow scrolling all of the password management list mode scre…
Browse files Browse the repository at this point in the history
…en" (#5445)

Task/Issue URL:
https://app.asana.com/0/608920331025315/1209106756565265/f

### Description
Reverts changes made in #5377
as it introduces performance issues on the password management screen
with larger password list sizes. Depending on the device / list size, it
can be crippling performance.

### Steps to test this PR
- [x] install `internal` variant to make the next step easier
- [x] Add 500+ passwords (can be done in `Autofill Dev Settings` screen,
using the **Add a lot of sample logins** button)
- [x] Visit password management screen and verify there isn’t a huge
delay in rendering the password list

For contrast, if you try this on `develop` you will notice a large perf
issue.

Co-authored-by: Craig Russell <[email protected]>
  • Loading branch information
CDRussell and CDRussell authored Jan 8, 2025
1 parent 6cd1dfc commit c997030
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,9 @@
<androidx.recyclerview.widget.RecyclerView
android:id="@+id/logins"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_height="0dp"
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/topDivider" />
Expand Down

0 comments on commit c997030

Please sign in to comment.