-
Notifications
You must be signed in to change notification settings - Fork 927
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Privacy Pro onboarding experiment (#4909)
Task/Issue URL: https://app.asana.com/0/1201807753394693/1207814889563330/f ### Description Added a new onboarding dialog containing information about Privacy Pro ### Steps to test this PR _Pre steps_ - [x] Change privacy-config URL for `PRIVACY_REMOTE_CONFIG_URL = "https://jsonblob.com/api/1279046082855034880"` - [x] Make sure you remove DuckDuckGo folder under Downloads directory _privacyPro dialog (Learn More)_ - [x] Change JsonBlob variant filters in order to assign `mr` which is the experimental variant - under `experimentalVariants` set `privacyProEligible` to false/true for `mr` and `mq` `weight` to 0 so you get assigned `mr` > "filters": { > "privacyProEligible": false/true > } - [x] Fresh install - [x] Go to a site - [x] Dismiss trackers dialog - [x] Open a new tab - [x] End dialog will appear - [x] Dismiss dialog tapping in High Five! button - [x] Check new privacy pro message is shown - [x] Check keyboard is hidden - [x] Tap on "learn more" - [x] Check you are redirected to Privacy Pro - [x] Open browser - [x] Check you don't see any onboarding Dax dialog in the new tab page _privacyPro dialog (Skip)_ - [x] Change JsonBlob variant filters in order to assign `mr` which is the experimental variant - under `experimentalVariants` set `privacyProEligible` to false/true for `mr` and `mq` `weight` to 0 so you get assigned `mr` > "filters": { > "privacyProEligible": false/true > } - [x] Fresh install - [x] Go to a site - [x] Dismiss trackers dialog - [x] Tap on Fire Button -> Clear data - [x] End dialog will appear - [x] Perform a search - [x] Open a new tab - [x] Check new privacy pro message is shown - [x] Check keyboard is hidden - [x] Tap on "skip" - [x] check Privacy pro dialog is dismissed and New Tab Page is shown _Control variant_ - [x] Change JsonBlob variant filters in order to assign `mq` which is the control variant - under `experimentalVariants` set `privacyProEligible` to false/true for `mq` and `mr` `weight` to 0 so you get assigned `mq` > "filters": { > "privacyProEligible": false/true > } - [x] Fresh install - [x] Go to a site - [x] Dismiss trackers dialog - [x] Open a new tab - [x] Check end dialog is shown - [x] Dismiss dialog and check onboarding is finished so new tab page is shown ### UI changes Privacy Pro dialog | Light Mode | Dark Mode | | ------ | ----- | ![privacy-pro-dialog-light](https://github.com/user-attachments/assets/73d777c2-bb86-4878-b32e-81ff14affb3e)|![privacy-pro-dialog-dark](https://github.com/user-attachments/assets/0b6eea0d-161f-4605-ae7b-4c764e91f76f)| ### UI changes End dialog | Before | After | | ------ | ----- | ![Screenshot_20240828_181212_DuckDuckGo](https://github.com/user-attachments/assets/f42cd8d6-fb33-413b-8288-df45ab270ddc)|![end-dialog-light](https://github.com/user-attachments/assets/73f20dd2-abe0-4183-a513-87bdaeceb342)|
- Loading branch information
Showing
11 changed files
with
310 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.