Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
technically this can obviously be anything but I'd rather use the default we agreed on in the tests too. The ShowOnAppLaunchPrefsDataStoreTest covers whether the default url is correct or not
  • Loading branch information
mikescamell committed Sep 18, 2024
1 parent 36afe9a commit f474d12
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class ShowOnAppLaunchViewModelTest {
testee.viewState.test {
val initialState = awaitItem()
assertEquals(LastOpenedTab, initialState.selectedOption)
assertEquals("duckduckgo.com", initialState.specificPageUrl)
assertEquals("https://duckduckgo.com", initialState.specificPageUrl)
}
}

Expand Down Expand Up @@ -85,7 +85,7 @@ class ShowOnAppLaunchViewModelTest {
private class FakeUrlConverter : UrlConverter {

override fun convertUrl(url: String?): String {
return url ?: "duckduckgo.com"
return url ?: "https://duckduckgo.com"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class FakeShowOnAppLaunchOptionDataStore(defaultOption: ShowOnAppLaunchOption? =

private var currentOptionStateFlow = MutableStateFlow(defaultOption)

private var currentSpecificPageUrl = MutableStateFlow("duckduckgo.com")
private var currentSpecificPageUrl = MutableStateFlow("https://duckduckgo.com")

override val optionFlow: Flow<ShowOnAppLaunchOption> = currentOptionStateFlow.asStateFlow().filterNotNull()

Expand Down

0 comments on commit f474d12

Please sign in to comment.