-
Notifications
You must be signed in to change notification settings - Fork 928
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Break build if active plugins are not in app scope (#4977)
Task/Issue URL: https://app.asana.com/0/1198194956794324/1208197444733454/f ### Description Active plugins can only be used in AppScope. Break the build if they're wrongly scoped. ### Steps to test this PR _Test_ * Change the scope of an already existing plugin (eg. `AutofillNewTabShortcutPlugin`) * clean build [ ] verify build fails with proper message
- Loading branch information
Showing
3 changed files
with
44 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...b-page-impl/src/main/java/com/duckduckgo/newtabpage/impl/FocusedViewPluginPointTrigger.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Copyright (c) 2024 DuckDuckGo | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.duckduckgo.newtabpage.impl | ||
|
||
import com.duckduckgo.anvil.annotations.ContributesActivePluginPoint | ||
import com.duckduckgo.di.scopes.AppScope | ||
import com.duckduckgo.newtabpage.api.FocusedViewPlugin | ||
|
||
@ContributesActivePluginPoint( | ||
scope = AppScope::class, | ||
boundType = FocusedViewPlugin::class, | ||
) | ||
private interface FocusedViewPluginPointTrigger |