Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "During beta" from banner in main view #3931

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Nov 27, 2023

Task/Issue URL: https://app.asana.com/0/0/1205217801169319/f

Description

See title
https://dashboard.smartling.com/app/projects/b01b53ede/account-jobs/b01b53ede:82gtdbvplyqu?filter=ALL

Steps to test this PR

Feature 1

  • Enable AppTP
  • Go to AppTP main view
  • Check the banner doesn't start with "During beta"

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

CrisBarreiro and others added 20 commits November 27, 2023 16:21
Translate strings-vpn to values-fi
Translate strings-vpn to values-it
Translate strings-vpn to values-ru
Translate strings-vpn to values-lv
Translate strings-vpn to values-sv
Translate strings-vpn to values-sk
Translate strings-vpn to values-ro
Translate strings-vpn to values-tr
Translate strings-vpn to values-cs
Translate strings-vpn to values-lt
Translate strings-vpn to values-el
Translate strings-vpn to values-pt
Translate strings-vpn to values-hr
Translate strings-vpn to values-fr
Translate strings-vpn to values-es
Translate strings-vpn to values-nb
Translate strings-vpn to values-da
Translate strings-vpn to values-pl
Translate strings-vpn to values-nl
Translate strings-vpn to values-et
Translate strings-vpn to values-de
Translate strings-vpn to values-hu
Translate strings-vpn to values-bg
Translate strings-autofill-impl to values-nl
Translate strings-autofill-impl to values-it
Translate strings-autofill-impl to values-ro
Translate strings-autofill-impl to values-sk
Translate strings-autofill-impl to values-sv
Translate strings-autofill-impl to values-bg
Translate strings-autofill-impl to values-fr
Translate strings-autofill-impl to values-sl
Translate strings-autofill-impl to values-lt
Translate strings-autofill-impl to values-el
Translate strings-autofill-impl to values-pt
Translate strings-autofill-impl to values-et
Translate strings-autofill-impl to values-nb
Translate strings-autofill-impl to values-de
Translate strings-autofill-impl to values-ru
Translate strings-autofill-impl to values-tr
Translate strings-autofill-impl to values-hu
Translate strings-autofill-impl to values-fi
Translate strings-autofill-impl to values-lv
Translate strings-autofill-impl to values-pl
Translate strings-autofill-impl to values-da
Translate strings-autofill-impl to values-es
Translate strings-autofill-impl to values-cs
Translate strings-vpn to values-tr
Translate strings-vpn to values-pt
Translate strings-vpn to values-hr
Translate strings-vpn to values-cs
@CrisBarreiro CrisBarreiro changed the base branch from develop to feature/cbarreiro/remove-apptp-beta-label November 28, 2023 13:23
@CrisBarreiro CrisBarreiro changed the base branch from feature/cbarreiro/remove-apptp-beta-label to develop November 28, 2023 13:23
@CrisBarreiro CrisBarreiro changed the base branch from develop to feature/cbarreiro/remove-apptp-beta-label November 28, 2023 14:56
@CrisBarreiro CrisBarreiro merged commit ec5f224 into feature/cbarreiro/remove-apptp-beta-label Nov 28, 2023
6 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cbarreiro/remove-beta-label-main-view-l10n branch November 28, 2023 14:57
CrisBarreiro added a commit that referenced this pull request Dec 4, 2023
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
If your PR does not involve UI changes, you can remove the **UI
changes** section

At a minimum, make sure your changes are tested in API 23 and one of the
more recent API levels available.
-->

Task/Issue URL: https://app.asana.com/0/0/1205217801169319/f

### Description
See title

https://dashboard.smartling.com/app/projects/b01b53ede/account-jobs/b01b53ede:82gtdbvplyqu?filter=ALL

### Steps to test this PR

_Feature 1_
- [x] Enable AppTP
- [x] Go to AppTP main view
- [x] Check the banner doesn't start with "During beta"

### UI changes
| Before  | After |
| ------ | ----- |
!(Upload before screenshot)|(Upload after screenshot)|

---------

Co-authored-by: root <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants