-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FDroid build #4949
Merged
Merged
Fix FDroid build #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
lmac012
force-pushed
the
fix/lukasz/fdroid-build
branch
from
August 28, 2024 15:22
027ec93
to
6b1f915
Compare
lmac012
force-pushed
the
feature/lukasz/fdroid-ci-check
branch
from
August 28, 2024 19:07
64f274e
to
9388486
Compare
lmac012
force-pushed
the
fix/lukasz/fdroid-build
branch
from
August 28, 2024 19:07
6b1f915
to
c072867
Compare
lmac012
force-pushed
the
feature/lukasz/fdroid-ci-check
branch
from
August 28, 2024 19:20
9388486
to
0659fdd
Compare
lmac012
force-pushed
the
fix/lukasz/fdroid-build
branch
from
August 28, 2024 19:20
c072867
to
cee2637
Compare
lmac012
force-pushed
the
feature/lukasz/fdroid-ci-check
branch
from
August 28, 2024 19:36
0659fdd
to
97d71e3
Compare
lmac012
force-pushed
the
fix/lukasz/fdroid-build
branch
from
August 28, 2024 19:36
cee2637
to
f88c17b
Compare
lmac012
force-pushed
the
feature/lukasz/fdroid-ci-check
branch
from
August 28, 2024 20:49
97d71e3
to
9baeffb
Compare
lmac012
force-pushed
the
fix/lukasz/fdroid-build
branch
from
August 28, 2024 20:50
f88c17b
to
6a62496
Compare
@CrisBarreiro FYI. This will have conflicts with your Duck Player PR. Lukasz moved the logic to check if it's a privacyPro url to its own module. |
nalcalag
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works as expected
lmac012
force-pushed
the
fix/lukasz/fdroid-build
branch
from
August 29, 2024 14:42
6a62496
to
893be19
Compare
lmac012
force-pushed
the
fix/lukasz/fdroid-build
branch
from
August 29, 2024 15:19
893be19
to
c0f81b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208148719076009/f
Description
Steps to test this PR
No UI changes