Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FDroid build #4949

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix FDroid build #4949

merged 2 commits into from
Aug 29, 2024

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Aug 28, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1208148719076009/f

Description

Steps to test this PR

  • Fresh install (internal or play flavor)
  • Navigate to duckduckgo.com/pro
  • Check onboarding in-context dialog is not shown
  • Perform a search
  • check SERP in-context dialog is shown

No UI changes

@lmac012
Copy link
Contributor Author

lmac012 commented Aug 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lmac012 and the rest of your teammates on Graphite Graphite

@lmac012 lmac012 mentioned this pull request Aug 28, 2024
@lmac012 lmac012 force-pushed the fix/lukasz/fdroid-build branch from 027ec93 to 6b1f915 Compare August 28, 2024 15:22
@lmac012 lmac012 force-pushed the feature/lukasz/fdroid-ci-check branch from 64f274e to 9388486 Compare August 28, 2024 19:07
@lmac012 lmac012 force-pushed the fix/lukasz/fdroid-build branch from 6b1f915 to c072867 Compare August 28, 2024 19:07
@lmac012 lmac012 force-pushed the feature/lukasz/fdroid-ci-check branch from 9388486 to 0659fdd Compare August 28, 2024 19:20
@lmac012 lmac012 force-pushed the fix/lukasz/fdroid-build branch from c072867 to cee2637 Compare August 28, 2024 19:20
@lmac012 lmac012 force-pushed the feature/lukasz/fdroid-ci-check branch from 0659fdd to 97d71e3 Compare August 28, 2024 19:36
@lmac012 lmac012 force-pushed the fix/lukasz/fdroid-build branch from cee2637 to f88c17b Compare August 28, 2024 19:36
@lmac012 lmac012 force-pushed the feature/lukasz/fdroid-ci-check branch from 97d71e3 to 9baeffb Compare August 28, 2024 20:49
@lmac012 lmac012 force-pushed the fix/lukasz/fdroid-build branch from f88c17b to 6a62496 Compare August 28, 2024 20:50
@lmac012 lmac012 marked this pull request as ready for review August 29, 2024 08:44
@lmac012 lmac012 requested a review from nalcalag August 29, 2024 12:20
@nalcalag
Copy link
Contributor

@CrisBarreiro FYI. This will have conflicts with your Duck Player PR. Lukasz moved the logic to check if it's a privacyPro url to its own module.

Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected

@lmac012 lmac012 force-pushed the fix/lukasz/fdroid-build branch from 6a62496 to 893be19 Compare August 29, 2024 14:42
Base automatically changed from feature/lukasz/fdroid-ci-check to develop August 29, 2024 15:09
@lmac012 lmac012 force-pushed the fix/lukasz/fdroid-build branch from 893be19 to c0f81b6 Compare August 29, 2024 15:19
@lmac012 lmac012 merged commit 74b939d into develop Aug 29, 2024
7 checks passed
@lmac012 lmac012 deleted the fix/lukasz/fdroid-build branch August 29, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants