Show on App Launch: Fix website showing after clear data action #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
51 tasks
mikescamell
merged commit 36f9161
into
feature/mike/show-on-app-launch/open-specific-url-tab-if-exists
6 of 7 checks passed
mikescamell
deleted the
feature/mike/show-on-app-launch/open-ntp-when-data-cleared
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208588631698784/f
Description
When clearing data with the fire button the website set for Specific Page would load if that option was enabled.
This stops that happening and instead shows the new tab page.
Steps to test this PR
Fire button
UI changes
N/A
Demo
Screen_recording_20241021_173539.mp4